fix(router): fix attempt status for techincal failures in psync flow #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-harsha-vardhan
added
A-core
sai-harsha-vardhan
requested review from
jarnura,
SanchithHegde and
Narayanbhat166
Narayanbhat166
requested changes
Sep 21, 2023
Comment on lines
318
to
319
| if flow_name == "PSync" { | ||
| payment_data.payment_attempt.status |
There was a problem hiding this comment.
here we are not allowing the status to be changed in case of genuine error too, this can be handled by checking the status code and then updating status
Narayanbhat166
previously approved these changes
Sep 21, 2023
jarnura
requested changes
Sep 22, 2023
jarnura
previously approved these changes
Sep 22, 2023
sai-harsha-vardhan
dismissed stale reviews from jarnura and Narayanbhat166
via
de426e3
Narayanbhat166
approved these changes
Sep 22, 2023
jarnura
approved these changes
Sep 22, 2023
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
fix attempt status for techincal failures in psync flow
Additional Changes
Motivation and Context
How did you test it?
4xx in payments confirm flow, payment status would be marked as failure
4xx in payments retrieve flow with force_sync = true for processing payment, status is unchanged
Checklist
cargo +nightly fmt --allcargo clippy