feat(db): add find_config_by_key_unwrap_or #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhicodes-crypto
added
A-framework
|
Race conditions could happen here . Will raise a separate PR for enabling locking for this table. |
jarnura
approved these changes
Sep 21, 2023
inventvenkat
approved these changes
Sep 21, 2023
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
add find_config_by_key_unwrap_or , so that the default value is inserted in DB and cached for faster retrievals.
Additional Changes
Motivation and Context
How did you test it?
Compiles
Checklist
cargo +nightly fmt --allcargo clippy