Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector): [bluesnap]Enhance currency Mapping with ConnectorCurrencyCommon Trait #2193

Merged
merged 2 commits into from
Sep 26, 2023
Merged

refactor(connector): [bluesnap]Enhance currency Mapping with ConnectorCurrencyCommon Trait #2193

merged 2 commits into from
Sep 26, 2023

Conversation

srujanchikke
Copy link
Contributor

@srujanchikke srujanchikke commented Sep 20, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This pull request introduces the get_currecny_unit from ConnectorCommon trait for Bluesnap. This function allows connectors to declare their accepted currency unit as either "Base" or "Minor" .For bluesnap it accepts currency as Base.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@srujanchikke srujanchikke added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Sep 20, 2023
@srujanchikke srujanchikke requested a review from a team as a code owner September 20, 2023 07:12
@srujanchikke srujanchikke self-assigned this Sep 20, 2023
@ArjunKarthik ArjunKarthik added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Sep 26, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 6db60b8 Sep 26, 2023
10 checks passed
@ArjunKarthik ArjunKarthik deleted the bluesnap_currency_conversion branch September 26, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamraatBansal SamraatBansal SamraatBansal approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@prasunna09 prasunna09 Awaiting requested review from prasunna09

Assignees

@srujanchikke srujanchikke

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srujanchikke @ArjunKarthik @SamraatBansal @SanchithHegde