refactor(connector): [Paypal]Enhance currency Mapping with ConnectorCurrencyCommon Trait #2191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Problem : Currently, amount mapping for different connectors are handled by hard coding dollars/cents which has been leading to multiple bugs due to incorrect mapping. Need to handle this better in code by having separate types for dollar vs cents .
Solution : To address this issue and improve code maintainability, this pull request introduces the get_currecny_unit from ConnectorCommon trait. This function allows connectors to declare their accepted currency unit as either "Base" or "Minor" .
Additional Changes
Motivation and Context
Implement the ConnectorCurrencyCommon trait, where you can declare the accepted currency unit (either Base or Minor) using the get_currency_unit method in ConnectorCommon trait .
How did you test it?
tested it locally
Checklist
cargo +nightly fmt --all
cargo clippy