Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): eliminate business profile database queries in payments confirm flow #2190

Merged
merged 7 commits into from
Sep 22, 2023
Merged

refactor(core): eliminate business profile database queries in payments confirm flow #2190

merged 7 commits into from
Sep 22, 2023

Conversation

nitesh-balla
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Removing db calls which are unnecessary

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Sep 20, 2023
@nitesh-balla nitesh-balla marked this pull request as ready for review September 20, 2023 08:36
@nitesh-balla nitesh-balla requested review from a team as code owners September 20, 2023 08:36
@nitesh-balla nitesh-balla changed the title Fix/remove redundant db calls Refactor: optimize database queries Sep 20, 2023
@nitesh-balla nitesh-balla changed the title Refactor: optimize database queries refactor: optimize database queries Sep 20, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Sep 20, 2023
@nitesh-balla nitesh-balla changed the title refactor: optimize database queries refactor(core): optimize database queries Sep 20, 2023
@nitesh-balla nitesh-balla changed the title refactor(core): optimize database queries refactor(core): remove redundant database queries Sep 20, 2023
@nitesh-balla nitesh-balla changed the title refactor(core): remove redundant database queries refactor(core): eliminate redundant or unnecessary database queries Sep 20, 2023
@nitesh-balla nitesh-balla changed the title refactor(core): eliminate redundant or unnecessary database queries refactor(core): eliminate business profile database queries in payments confirm flow Sep 20, 2023
@nitesh-balla nitesh-balla self-assigned this Sep 20, 2023
@nitesh-balla nitesh-balla added C-refactor Category: Refactor S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Sep 20, 2023
inventvenkat
inventvenkat requested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@inventvenkat inventvenkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this should validate is been passed everywhere?

@inventvenkat inventvenkat added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit 90e4392 Sep 22, 2023
10 checks passed
@inventvenkat inventvenkat deleted the fix/remove-redundant-db-calls branch September 22, 2023 09:22
@shakthi-22 shakthi-22 added this to the September 2023 Milestone milestone Sep 22, 2023
@shakthi-22 shakthi-22 removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Sep 22, 2023
@shakthi-22 shakthi-22 linked an issue Sep 22, 2023 that may be closed by this pull request
[REFACTOR]: [OpenNode] Remove Default Case Handling #2280
Closed
2 tasks
@shakthi-22 shakthi-22 removed a link to an issue Sep 22, 2023
[REFACTOR]: [OpenNode] Remove Default Case Handling #2280
Closed
2 tasks
@shakthi-22 shakthi-22 restored the fix/remove-redundant-db-calls branch September 22, 2023 11:37
@shakthi-22 shakthi-22 deleted the fix/remove-redundant-db-calls branch September 22, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@inventvenkat inventvenkat inventvenkat approved these changes

@jarnura jarnura Awaiting requested review from jarnura

@NishantJoshi00 NishantJoshi00 Awaiting requested review from NishantJoshi00

Assignees

@nitesh-balla nitesh-balla

Labels
C-refactor Category: Refactor
Projects
None yet
Milestone
September 2023 Milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitesh-balla @inventvenkat @Narayanbhat166 @shakthi-22