Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): error thrown for wrong mca in applepay_verification flow change from 5xx to 4xx #2189

Merged
merged 6 commits into from
Sep 20, 2023
Merged

refactor(core): error thrown for wrong mca in applepay_verification flow change from 5xx to 4xx #2189

merged 6 commits into from
Sep 20, 2023

Conversation

prajjwalkumar17
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

error thrown for wrong mca in applepay_verification flow change from 5xx to 4xx

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prajjwalkumar17 prajjwalkumar17 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor A-errors Area: error messages, structure & logging R-waiting-on-L1 Review: Waiting on L1 reviewer R-waiting-on-L2 Review: Waiting on L2 reviewer labels Sep 20, 2023
@prajjwalkumar17 prajjwalkumar17 self-assigned this Sep 20, 2023
@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner September 20, 2023 06:44
vspecky
vspecky previously approved these changes Sep 20, 2023
View reviewed changes
@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner September 20, 2023 07:21
@tinu-hareesswar tinu-hareesswar added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit 656e710 Sep 20, 2023
10 checks passed
@tinu-hareesswar tinu-hareesswar deleted the fix/applepay_req_case branch September 20, 2023 08:27
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Sep 24, 2023
@SanchithHegde SanchithHegde removed the R-waiting-on-L2 Review: Waiting on L2 reviewer label Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vspecky vspecky vspecky approved these changes

@lsampras lsampras lsampras approved these changes

@jarnura jarnura Awaiting requested review from jarnura

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

Assignees

@prajjwalkumar17 prajjwalkumar17

Labels
A-core Area: Core flows A-errors Area: error messages, structure & logging C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prajjwalkumar17 @lsampras @vspecky @tinu-hareesswar @SanchithHegde