feat(connector): [Gocardless] add boilerplate code #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArjunKarthik
added
A-connector-integration
ArjunKarthik
commented
Sep 18, 2023
| @@ -76,7 +77,7 @@ impl ConnectorAuthentication { | |||
| /// Will panic if `CONNECTOR_AUTH_FILE_PATH` env is not set | |||
| #[allow(clippy::expect_used)] | |||
| pub fn new() -> Self { | |||
| // Do `export CONNECTOR_AUTH_FILE_PATH="/hyperswitch/crates/router/tests/connectors/sample_auth.toml"` | |||
| // Do `export CONNECTOR_AUTH_FILE_PATH="/hyperswitch/crates/router/tests/connectors/sample_sample_auth.toml"` | |||
There was a problem hiding this comment.
This was added by the script, Will revert in next PR<
prasunna09
reviewed
Sep 18, 2023
| @@ -142,6 +142,7 @@ impl<const T: u8> | |||
| } | |||
|
|
|||
| default_imp_for_complete_authorize!( | |||
| connector::Gocardless, | |||
There was a problem hiding this comment.
Please maintain the order here as well as in the other default implementations.
There was a problem hiding this comment.
@prasunna09 I resolved it in a separate PR -#2180. Will raise once testing is completed
SamraatBansal
previously approved these changes
Sep 18, 2023
prasunna09
requested changes
Sep 18, 2023
prasunna09
approved these changes
Sep 18, 2023
SamraatBansal
approved these changes
Sep 18, 2023
SanchithHegde
approved these changes
Sep 18, 2023
ArjunKarthik
added
S-ready-for-merge
and removed
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Gocardless new connector integration
Additional Changes
Checklist
cargo +nightly fmt --allcargo clippy