Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pm_auth): add plaid to connector list #2166

Merged
merged 8 commits into from
Sep 15, 2023
Merged

feat(pm_auth): add plaid to connector list #2166

merged 8 commits into from
Sep 15, 2023

Conversation

Chethan-rao
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR includes plaid (payment method auth validation connector) to existing connector list

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Chethan-rao Chethan-rao added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Sep 14, 2023
@Chethan-rao Chethan-rao added this to the September 2023 Milestone milestone Sep 14, 2023
@Chethan-rao Chethan-rao requested a review from a team as a code owner September 14, 2023 16:55
@Chethan-rao Chethan-rao self-assigned this Sep 14, 2023
@Chethan-rao Chethan-rao requested a review from a team as a code owner September 14, 2023 16:55
SanchithHegde
SanchithHegde reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

crates/router/src/core/admin.rs Outdated Show resolved Hide resolved
crates/router/src/types/api.rs Outdated Show resolved Hide resolved
SanchithHegde
SanchithHegde previously approved these changes Sep 14, 2023
View reviewed changes
vspecky
vspecky requested changes Sep 15, 2023
View reviewed changes
crates/api_models/src/enums.rs Outdated Show resolved Hide resolved
@Chethan-rao Chethan-rao requested a review from a team as a code owner September 15, 2023 07:04
@vspecky vspecky added this pull request to the merge queue Sep 15, 2023
Merged via the queue into main with commit 0bc99ad Sep 15, 2023
8 checks passed
@vspecky vspecky deleted the add_plaid_as_connector branch September 15, 2023 07:42
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vspecky vspecky vspecky approved these changes

@lsampras lsampras lsampras approved these changes

@Aprabhat19 Aprabhat19 Awaiting requested review from Aprabhat19

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

Assignees

@Chethan-rao Chethan-rao

Labels
C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
September 2023 Milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chethan-rao @lsampras @SanchithHegde @vspecky