Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move Request and RequestBuilder structs to common_utils crate #2145

Merged
merged 5 commits into from
Sep 13, 2023
Merged

refactor: move Request and RequestBuilder structs to common_utils crate #2145

merged 5 commits into from
Sep 13, 2023

Conversation

Chethan-rao
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Currently Request and RequestBuilder structs reside in router crate. Since these are common structs used while building requests for connectors, it's better to move these to common_utils crate. This also reduces dependency on router crate for such things

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Chethan-rao Chethan-rao added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Sep 13, 2023
@Chethan-rao Chethan-rao added this to the September 2023 Milestone milestone Sep 13, 2023
@Chethan-rao Chethan-rao self-assigned this Sep 13, 2023
@Chethan-rao Chethan-rao changed the title refactor: move Request and RequestBuilder structs to common_utils crate" refactor: move Request and RequestBuilder structs to common_utils crate Sep 13, 2023
@Chethan-rao Chethan-rao linked an issue Sep 13, 2023 that may be closed by this pull request
[REFACTOR] Move Request and RequestBuilder structs to common_utils crate #2144
Closed
2 tasks
@vspecky vspecky added A-core Area: Core flows S-ready-for-merge R-L1-completed Review: L1 Review completed R-L2-completed Review: L2 Review completed labels Sep 13, 2023
@vspecky vspecky added this pull request to the merge queue Sep 13, 2023
Merged via the queue into main with commit 21be67a Sep 13, 2023
11 of 12 checks passed
@vspecky vspecky deleted the refactor_api_request branch September 13, 2023 10:43
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed S-ready-for-merge R-L1-completed Review: L1 Review completed labels Sep 13, 2023
@SanchithHegde SanchithHegde removed the R-L2-completed Review: L2 Review completed label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vspecky vspecky vspecky approved these changes

@lsampras lsampras lsampras approved these changes

@jarnura jarnura Awaiting requested review from jarnura

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@Chethan-rao Chethan-rao

Labels
A-core Area: Core flows C-refactor Category: Refactor
Projects
None yet
Milestone
September 2023 Milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] Move Request and RequestBuilder structs to common_utils crate
4 participants
@Chethan-rao @lsampras @vspecky @SanchithHegde