Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): [Bluesnap] Add secondary_base_url for script #2124

Merged
merged 3 commits into from
Sep 11, 2023
Merged

fix(core): [Bluesnap] Add secondary_base_url for script #2124

merged 3 commits into from
Sep 11, 2023

Conversation

Sakilmostak
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Url was hardcoded in the script which is changed and moved to configs

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration A-core Area: Core flows C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-configuration-changes Metadata: This PR involves configuration changes labels Sep 11, 2023
@Sakilmostak Sakilmostak requested a review from a team as a code owner September 11, 2023 14:52
@Sakilmostak Sakilmostak self-assigned this Sep 11, 2023
@Sakilmostak Sakilmostak requested a review from a team as a code owner September 11, 2023 14:52
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Sep 11, 2023
Merged via the queue into main with commit 1407049 Sep 11, 2023
10 checks passed
@Narayanbhat166 Narayanbhat166 deleted the fix/bluesnap_script branch September 11, 2023 15:42
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@Sakilmostak Sakilmostak

Labels
A-connector-integration Area: Connector integration A-core Area: Core flows C-bug Category: Bug M-configuration-changes Metadata: This PR involves configuration changes
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sakilmostak @ArjunKarthik @Narayanbhat166 @SanchithHegde