Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): new get route for derivation of verified applepay domain #2121

Merged
merged 7 commits into from
Sep 12, 2023
Merged

feat(router): new get route for derivation of verified applepay domain #2121

merged 7 commits into from
Sep 12, 2023

Conversation

prajjwalkumar17
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Derivation of verified applepay domains for a profile_id.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prajjwalkumar17 prajjwalkumar17 added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payment-methods Area: Payment Methods M-api-contract-changes Metadata: This PR involves API contract changes R-waiting-on-L1 Review: Waiting on L1 reviewer labels Sep 11, 2023
@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner September 11, 2023 11:44
@prajjwalkumar17 prajjwalkumar17 self-assigned this Sep 11, 2023
vspecky
vspecky previously approved these changes Sep 11, 2023
View reviewed changes
SanchithHegde
SanchithHegde reviewed Sep 11, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

crates/router/src/lib.rs Outdated Show resolved Hide resolved
crates/api_models/src/verifications.rs Outdated Show resolved Hide resolved
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Sep 12, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit 177d8e5 Sep 12, 2023
10 checks passed
@SanchithHegde SanchithHegde deleted the feat/get_applepay_verified_domains branch September 12, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vspecky vspecky vspecky approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Sangamesh26 Sangamesh26 Awaiting requested review from Sangamesh26

Assignees

@prajjwalkumar17 prajjwalkumar17

Labels
A-payment-methods Area: Payment Methods C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prajjwalkumar17 @SanchithHegde @vspecky