Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): revert checkout apple pay to tokenization flow #2110

Merged
merged 2 commits into from
Sep 8, 2023
Merged

fix(connector): revert checkout apple pay to tokenization flow #2110

merged 2 commits into from
Sep 8, 2023

Conversation

ShankarSinghC
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screenshot 2023-09-08 at 6 24 18 PM Screenshot 2023-09-08 at 6 24 40 PM Screenshot 2023-09-08 at 6 25 08 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ShankarSinghC ShankarSinghC added C-bug Category: Bug C-refactor Category: Refactor R-waiting-on-L1 Review: Waiting on L1 reviewer labels Sep 8, 2023
@ShankarSinghC ShankarSinghC self-assigned this Sep 8, 2023
@ShankarSinghC ShankarSinghC requested a review from a team as a code owner September 8, 2023 13:25
@ShankarSinghC ShankarSinghC changed the title fix(connector): [checkout, stripe] use display impl for expiry date fix(connector): revert checkout apple pay to tokenization flow Sep 8, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Sep 8, 2023
Merged via the queue into main with commit cc5add6 Sep 8, 2023
11 checks passed
@SanchithHegde SanchithHegde deleted the fix_checkout_apple_pay branch September 8, 2023 14:29
@SanchithHegde SanchithHegde removed the R-waiting-on-L1 Review: Waiting on L1 reviewer label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prajjwalkumar17 prajjwalkumar17 prajjwalkumar17 approved these changes

@Sangamesh26 Sangamesh26 Sangamesh26 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@ShankarSinghC ShankarSinghC

Labels
C-bug Category: Bug C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShankarSinghC @SanchithHegde @Sangamesh26 @prajjwalkumar17