Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): send connection_closed errors as 5xx instead of 2xx #2093

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix(router): send connection_closed errors as 5xx instead of 2xx #2093

merged 1 commit into from
Sep 6, 2023

Conversation

sai-harsha-vardhan
Copy link
Contributor

@sai-harsha-vardhan sai-harsha-vardhan commented Sep 6, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

send connection_closed errors as 5xx instead of 2xx as connections are not being closed by external entities

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Sep 6, 2023
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Sep 6, 2023
@sai-harsha-vardhan sai-harsha-vardhan requested a review from a team as a code owner September 6, 2023 07:27
@sai-harsha-vardhan sai-harsha-vardhan changed the title fix(router): send connection_closed errors as 5xx instead of 2xx as issue is within application fix(router): send connection_closed errors as 5xx instead of 2xx Sep 6, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit 4d58bdb Sep 6, 2023
14 checks passed
@SanchithHegde SanchithHegde deleted the send-connection-closed-errors-as-5xx branch September 6, 2023 14:22
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NishantJoshi00 NishantJoshi00 NishantJoshi00 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels
A-core Area: Core flows C-bug Category: Bug
Projects
None yet
Milestone
September 2023 Milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sai-harsha-vardhan @SanchithHegde @NishantJoshi00