Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pm_list): add card - credit pm type required field info for connectors #2075

Merged
merged 2 commits into from
Sep 1, 2023
Merged

feat(pm_list): add card - credit pm type required field info for connectors #2075

merged 2 commits into from
Sep 1, 2023

Conversation

prasunna09
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add mandatory fields required for card payment method with payment method type - credit for all existing connectors

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

for credit -
Screenshot 2023-09-01 at 6 13 45 PM
for debit -
Screenshot 2023-09-01 at 6 14 09 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prasunna09 prasunna09 added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-configuration-changes Metadata: This PR involves configuration changes A-payment-methods Area: Payment Methods labels Sep 1, 2023
@prasunna09 prasunna09 added this to the September 2023 Milestone milestone Sep 1, 2023
@prasunna09 prasunna09 requested review from a team as code owners September 1, 2023 13:37
@prasunna09 prasunna09 self-assigned this Sep 1, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Sep 1, 2023
Merged via the queue into main with commit a882d76 Sep 1, 2023
11 of 12 checks passed
@SanchithHegde SanchithHegde deleted the add-required-field-for-credit-pm-type branch September 1, 2023 18:02
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chethan-rao Chethan-rao Chethan-rao approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@prasunna09 prasunna09

Labels
A-connector-integration Area: Connector integration A-payment-methods Area: Payment Methods C-feature Category: Feature request or enhancement M-configuration-changes Metadata: This PR involves configuration changes
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
September 2023 Milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prasunna09 @SanchithHegde @Chethan-rao