Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frm): enum variant misspelled changed from fullfillment to fulfillment #2065

Merged
merged 1 commit into from
Sep 4, 2023
Merged

feat(frm): enum variant misspelled changed from fullfillment to fulfillment #2065

merged 1 commit into from
Sep 4, 2023

Conversation

rishavkar
Copy link
Contributor

@rishavkar rishavkar commented Aug 31, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Enum variant mispelled...changed from fullfillment to fulfillment
This is required for the implementation of the fullfillment api

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

new api endpoint added... /frm_fulfillment
no existing endpoint changed...the foll. is the curl for the same :

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@rishavkar rishavkar requested a review from a team as a code owner August 31, 2023 13:08
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Aug 31, 2023
@rishavkar rishavkar changed the title Enum variant mispelled...changed from fullfillment to fulfillment feature(frm): Enum variant mispelled...changed from fullfillment to fulfillment Aug 31, 2023
@rishavkar rishavkar self-assigned this Aug 31, 2023
@rishavkar rishavkar added A-core Area: Core flows C-feature Category: Feature request or enhancement P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 31, 2023
@jagan-jaya jagan-jaya changed the title feature(frm): Enum variant mispelled...changed from fullfillment to fulfillment feature(frm): enum variant misspelled changed from fullfillment to fulfillment Sep 1, 2023
@jagan-jaya jagan-jaya changed the title feature(frm): enum variant misspelled changed from fullfillment to fulfillment feat(frm): enum variant misspelled changed from fullfillment to fulfillment Sep 1, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Sep 1, 2023
@jagan-jaya jagan-jaya added this pull request to the merge queue Sep 4, 2023
Merged via the queue into main with commit e1cebd4 Sep 4, 2023
11 of 19 checks passed
@jagan-jaya jagan-jaya deleted the frm_fullfillment_oss branch September 4, 2023 10:07
@SanchithHegde SanchithHegde removed P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

Assignees

@rishavkar rishavkar

Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rishavkar @jagan-jaya @jarnura @SanchithHegde