feat(core): add support for webhook additional source verification call for paypal #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srujanchikke
added
A-connector-integration
github-actions
bot
added
the
S-conventions-not-followed
srujanchikke
changed the title
github-actions
bot
removed
the
S-conventions-not-followed
…_verify Signed-off-by: chikke srujan <[email protected]>
srujanchikke
requested review from
jarnura,
ashokkjag and
a team
as code owners
| | PaypalWebhookEventType::CheckoutOrderProcessed => Ok(Self::Pending), | ||
| PaypalWebhookEventType::PaymentAuthorizationCreated => Ok(Self::Created), | ||
| PaypalWebhookEventType::PaymentCaptureRefunded => Ok(Self::Refunded), | ||
| _ => Err(errors::ConnectorError::WebhookEventTypeNotFound.into()), |
There was a problem hiding this comment.
Why are we throwing ConnectorError::WebhookEventTypeNotFound here? Please address it in other try_froms too
| ) -> CustomResult<String, errors::ConnectorError> { | ||
| let header_value = header | ||
| .get(key) | ||
| .ok_or(errors::ConnectorError::WebhookSourceVerificationFailed)? |
There was a problem hiding this comment.
Should we consider adding logs here, because it's hard to trace if something fails here?
ArjunKarthik
added
the
S-needs-conflict-resolution
srujanchikke
force-pushed
the
webhook_src_verify
branch
from
cc4eaed
to
ec71db3
Compare
SanchithHegde
previously approved these changes
Sep 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
srujanchikke
dismissed stale reviews from sai-harsha-vardhan, SanchithHegde, and ArjunKarthik
via
30dc704
ArjunKarthik
approved these changes
Sep 20, 2023
ArjunKarthik
added
the
S-waiting-on-author
srujanchikke
removed
the
S-waiting-on-author
Done! |
SanchithHegde
previously approved these changes
Sep 20, 2023
ArjunKarthik
approved these changes
Sep 20, 2023
ArjunKarthik
added
S-ready-for-merge
S-waiting-on-approval
SanchithHegde
approved these changes
Sep 20, 2023
SanchithHegde
removed
S-ready-for-merge
S-waiting-on-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Paypal needs additional verification call for webhook source verification . This pr adds support in webhooks flow for additional api call for source verification .
Additional Changes
Motivation and Context
Paypal needs additional verification call for webhook source verification . This pr adds support in webhooks flow for additional api call for source verification .
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy