-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add metrics for external api call #2021
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracarys18
added
A-core
Area: Core flows
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Aug 25, 2023
inventvenkat
previously approved these changes
Aug 25, 2023
Abhicodes-crypto
previously approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, other than that LGTM
Apart from what @Abhicodes-crypto commented LGTM! |
nitesh-balla
previously approved these changes
Aug 25, 2023
dracarys18
dismissed stale reviews from nitesh-balla, Abhicodes-crypto, and inventvenkat
via
August 28, 2023 07:39
ee9a4a3
dracarys18
requested review from
Abhicodes-crypto,
inventvenkat and
nitesh-balla
August 28, 2023 07:39
Abhicodes-crypto
previously approved these changes
Aug 28, 2023
…_for_external_call
Abhicodes-crypto
approved these changes
Aug 28, 2023
nitesh-balla
approved these changes
Aug 28, 2023
SanchithHegde
approved these changes
Aug 30, 2023
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added metrics for external API call this includes all connector calls and locker call.
Motivation and Context
Metrics for latency
How did you test it?
NA
Checklist
cargo +nightly fmt --all
cargo clippy