Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add metrics for external api call #2021

Merged
merged 5 commits into from
Aug 30, 2023

Conversation

dracarys18
Copy link
Member

Type of Change

  • Enhancement

Description

Added metrics for external API call this includes all connector calls and locker call.

Motivation and Context

Metrics for latency

How did you test it?

NA

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@dracarys18 dracarys18 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 25, 2023
@dracarys18 dracarys18 self-assigned this Aug 25, 2023
@dracarys18 dracarys18 requested review from a team as code owners August 25, 2023 11:06
inventvenkat
inventvenkat previously approved these changes Aug 25, 2023
Copy link
Contributor

@Abhicodes-crypto Abhicodes-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, other than that LGTM

crates/router/src/services/api.rs Outdated Show resolved Hide resolved
@nitesh-balla nitesh-balla self-requested a review August 25, 2023 13:03
@nitesh-balla
Copy link
Contributor

nitesh-balla commented Aug 25, 2023

Apart from what @Abhicodes-crypto commented LGTM!

nitesh-balla
nitesh-balla previously approved these changes Aug 25, 2023
crates/router/src/services/api.rs Show resolved Hide resolved
@SanchithHegde SanchithHegde added this pull request to the merge queue Aug 30, 2023
Merged via the queue into main with commit 08fb2a9 Aug 30, 2023
14 of 16 checks passed
@SanchithHegde SanchithHegde deleted the add_metrics_for_external_call branch August 30, 2023 18:01
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants