Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(payment): fix max limit on payment intents list #2014

Merged
merged 2 commits into from
Aug 25, 2023
Merged

fix(payment): fix max limit on payment intents list #2014

merged 2 commits into from
Aug 25, 2023

Conversation

lsampras
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Add max limit on transforms to common filter
  • Add offset for payment intents fetch

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

  • Currently we used a common limit across all api's which shouldn't be the case

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@lsampras lsampras added C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payments Area: payments labels Aug 25, 2023
@lsampras lsampras self-assigned this Aug 25, 2023
@lsampras lsampras marked this pull request as ready for review August 25, 2023 07:27
@lsampras lsampras requested a review from a team as a code owner August 25, 2023 07:27
lsampras
lsampras commented Aug 25, 2023
View reviewed changes
crates/data_models/src/payments/payment_intent.rs Outdated
@@ -419,7 +419,7 @@ impl From<api_models::payments::PaymentListFilterConstraints> for PaymentIntentF
customer_id: None,
starting_after_id: None,
ending_before_id: None,
limit: None,
limit: Some(20),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use consts

@apoorvdixit88 apoorvdixit88 requested review from a team as code owners August 25, 2023 07:54
@SanchithHegde SanchithHegde added this pull request to the merge queue Aug 25, 2023
Merged via the queue into main with commit a888953 Aug 25, 2023
12 of 14 checks passed
@SanchithHegde SanchithHegde deleted the fix_payment_intent_list branch August 25, 2023 09:24
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvdixit88 apoorvdixit88 apoorvdixit88 approved these changes

@NishantJoshi00 NishantJoshi00 NishantJoshi00 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@lsampras lsampras

Labels
A-payments Area: payments C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lsampras @SanchithHegde @NishantJoshi00 @apoorvdixit88