feat(router): verify service for applepay merchant registration #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prajjwalkumar17
added
C-feature
jarnura
requested changes
Aug 25, 2023
…/github.com/juspay/hyperswitch into feat/applepay_merchant_registration_service
jarnura
requested changes
Aug 29, 2023
…/github.com/juspay/hyperswitch into feat/applepay_merchant_registration_service
jarnura
previously approved these changes
Aug 29, 2023
Sangamesh26
reviewed
Aug 30, 2023
jarnura
approved these changes
Aug 31, 2023
prajjwalkumar17
removed
S-waiting-on-review
Comment on lines
+35
to
+51
| let applepay_internal_merchant_identifier = kms::get_kms_client(kms_config) | ||
| .await | ||
| .decrypt(encrypted_merchant_identifier) | ||
| .await | ||
| .change_context(api_error_response::ApiErrorResponse::InternalServerError)?; | ||
|
|
||
| let cert_data = kms::get_kms_client(kms_config) | ||
| .await | ||
| .decrypt(encrypted_cert) | ||
| .await | ||
| .change_context(api_error_response::ApiErrorResponse::InternalServerError)?; | ||
|
|
||
| let key_data = kms::get_kms_client(kms_config) | ||
| .await | ||
| .decrypt(encrypted_key) | ||
| .await | ||
| .change_context(api_error_response::ApiErrorResponse::InternalServerError)?; |
There was a problem hiding this comment.
Can we have this decrypted similar to all the other KMS decryptions that are being done? in kms.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
New verify flow for applepay merchant verification
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy