Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): added new webhook URL to support merchant_connector_id #2006

Merged
merged 20 commits into from
Sep 12, 2023
Merged

feat(router): added new webhook URL to support merchant_connector_id #2006

merged 20 commits into from
Sep 12, 2023

Conversation

sahkal
Copy link
Contributor

@sahkal sahkal commented Aug 24, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add Support for connector_id in webhook URL.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested in local

Screenshot 2023-08-28 at 6 24 38 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sahkal sahkal requested review from a team, jarnura and ashokkjag as code owners August 24, 2023 08:21
@sahkal sahkal self-assigned this Aug 28, 2023
@sahkal sahkal added A-webhooks Area: Webhook flows M-api-contract-changes Metadata: This PR involves API contract changes labels Aug 28, 2023
@sahkal sahkal added this to the August 2023 Milestone milestone Aug 28, 2023
@sahkal sahkal added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Aug 30, 2023
jarnura
jarnura requested changes Aug 31, 2023
View reviewed changes
crates/router/src/core/webhooks.rs Outdated Show resolved Hide resolved
@sahkal sahkal requested a review from jarnura August 31, 2023 14:46
jarnura
jarnura previously approved these changes Sep 1, 2023
View reviewed changes
Narayanbhat166
Narayanbhat166 requested changes Sep 4, 2023
View reviewed changes
crates/router/src/routes/app.rs Outdated Show resolved Hide resolved
crates/router/src/core/webhooks.rs Outdated Show resolved Hide resolved
crates/router/src/core/webhooks.rs Outdated Show resolved Hide resolved
@Narayanbhat166 Narayanbhat166 changed the title feat(router): added new webhook URL to support business_profile feat(router): added new webhook URL to support merchant_connector_id Sep 5, 2023
Narayanbhat166
Narayanbhat166 requested changes Sep 5, 2023
View reviewed changes
crates/router/src/core/webhooks.rs Outdated Show resolved Hide resolved
Narayanbhat166
Narayanbhat166 previously approved these changes Sep 12, 2023
View reviewed changes
SanchithHegde
SanchithHegde reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

crates/router/src/core/webhooks.rs Outdated Show resolved Hide resolved
crates/router/src/core/webhooks.rs Outdated Show resolved Hide resolved
SanchithHegde
SanchithHegde previously approved these changes Sep 12, 2023
View reviewed changes
Narayanbhat166
Narayanbhat166 previously approved these changes Sep 12, 2023
View reviewed changes
@Narayanbhat166 Narayanbhat166 dismissed stale reviews from SanchithHegde and themself via 2281089 September 12, 2023 18:54
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit 82b36e8 Sep 12, 2023
10 checks passed
@Narayanbhat166 Narayanbhat166 deleted the webhook-support-for-business-profile branch September 12, 2023 19:35
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jarnura jarnura jarnura left review comments

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@sahkal sahkal

Labels
A-webhooks Area: Webhook flows M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Milestone
September 2023 Milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sahkal @jarnura @SanchithHegde @Narayanbhat166 @bernard-eugine