feat(core): Connector specific validation for Payment Sync #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakilmostak
added
A-connector-integration
Sakilmostak
requested review from
a team,
jarnura and
ashokkjag
as code owners
Sakilmostak
changed the title
connector_request_reference_id as Transaction Id to Retrieve Payments
ArjunKarthik
requested changes
Aug 28, 2023
ArjunKarthik
added
the
S-waiting-on-author
Sakilmostak
removed
the
S-waiting-on-author
Sakilmostak
force-pushed
the
bluesnap_sync_refactor
branch
from
59e065e
to
35a92c3
Compare
ArjunKarthik
requested changes
Aug 29, 2023
| @@ -26,7 +26,7 @@ use crate::{ | |||
| configs::settings::Connectors, | |||
| connector, consts, | |||
| core::errors::{self, CustomResult}, | |||
| services::{request, ConnectorIntegration, ConnectorRedirectResponse}, | |||
| services::{request, ConnectorIntegration, ConnectorRedirectResponse, ConnectorValidation}, | |||
There was a problem hiding this comment.
Do we need this import?
There was a problem hiding this comment.
Yes, since we are adding this trait to Payment, this import was made to add ConnectorValidation trait for api crate itself otherwise for all file where payment is implemented, we need to import services crate too for ConnectorValidation
NishantJoshi00
requested changes
Aug 30, 2023
| None => types::ResponseId::NoResponseId, | ||
| }; | ||
|
|
||
| // [#44]: why should response be filled during request |
There was a problem hiding this comment.
We should in the future, also pick this up, as currently these are just work arounds
There was a problem hiding this comment.
Sure👍, will pick this up
NishantJoshi00
previously approved these changes
Aug 30, 2023
ArjunKarthik
approved these changes
Aug 30, 2023
NishantJoshi00
approved these changes
Aug 31, 2023
ArjunKarthik
added
S-ready-for-merge
and removed
R-waiting-on-L1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
connector_request_reference_idis being pass asmerchant_transaction_idwhich will help in payment retrieval in case of connector timeout.Whether psync call is made is now handled at connector level to decide what parameters are required to make the call
For Bluesnap,
merchant_idneeds to be passed in connector meta_data to enable this featureAdditional Changes
Checklist
cargo +nightly fmt --allcargo clippy