Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): made authenticate_client_secret function public #1992

Merged
merged 1 commit into from
Aug 23, 2023
Merged

refactor(core): made authenticate_client_secret function public #1992

merged 1 commit into from
Aug 23, 2023

Conversation

prajjwalkumar17
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Made the authenticate_client_secret function public for usage

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prajjwalkumar17 prajjwalkumar17 added A-core Area: Core flows P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor R-waiting-on-L1 Review: Waiting on L1 reviewer labels Aug 23, 2023
@prajjwalkumar17 prajjwalkumar17 added this to the August 2023 Milestone milestone Aug 23, 2023
@prajjwalkumar17 prajjwalkumar17 self-assigned this Aug 23, 2023
@prajjwalkumar17 prajjwalkumar17 added R-L2-completed Review: L2 Review completed and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Aug 23, 2023
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Aug 23, 2023
Merged via the queue into main with commit 6986772 Aug 23, 2023
11 of 12 checks passed
@Narayanbhat166 Narayanbhat166 deleted the fix/client_secret_expiry branch August 23, 2023 10:45
@SanchithHegde SanchithHegde removed P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-L2-completed Review: L2 Review completed labels Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jarnura jarnura jarnura approved these changes

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@prajjwalkumar17 prajjwalkumar17

Labels
A-core Area: Core flows C-refactor Category: Refactor
Projects
None yet
Milestone
August 2023 Milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prajjwalkumar17 @jarnura @Narayanbhat166 @SanchithHegde