Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): add fields in payments list response #1987

Merged
merged 2 commits into from
Aug 23, 2023
Merged

feat(router): add fields in payments list response #1987

merged 2 commits into from
Aug 23, 2023

Conversation

harshapathuri86
Copy link
Contributor

@harshapathuri86 harshapathuri86 commented Aug 22, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

added fields

  • business_label
  • business_country
  • business_sub_label
  • setup_future_usage
  • capture_method
  • authentication_type
  • connector_transaction_id
    in payments list response

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

closes #1967

How did you test it?

tested API endpoint locally to check if the fields are added to the response

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@harshapathuri86 harshapathuri86 requested a review from a team as a code owner August 22, 2023 19:52
@harshapathuri86 harshapathuri86 changed the title feat(router):add fields in payments list response #1967 feat(router):add fields in payments list response Aug 22, 2023
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Aug 22, 2023
@harshapathuri86 harshapathuri86 changed the title feat(router):add fields in payments list response feat(router): add fields in payments list response Aug 22, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Aug 22, 2023
@Narayanbhat166 Narayanbhat166 added C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes A-payments Area: payments labels Aug 23, 2023
Narayanbhat166
Narayanbhat166 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@Narayanbhat166 Narayanbhat166 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me! 🎉 Thanks for the PR @harshapathuri86

@SanchithHegde SanchithHegde merged commit abc736b into juspay:main Aug 23, 2023
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@apoorvdixit88 apoorvdixit88 Awaiting requested review from apoorvdixit88

Assignees

@harshapathuri86 harshapathuri86

Labels
A-payments Area: payments C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] add fields in payments list response
3 participants
@harshapathuri86 @SanchithHegde @Narayanbhat166