fix(webhooks): send stripe compatible webhooks for stripe compatible merchants #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhicodes-crypto
added
A-core
Narayanbhat166
previously approved these changes
Aug 23, 2023
|
please fix the failing checks |
Abhicodes-crypto
force-pushed
the
compatible-webhooks-fix
branch
from
402797a
to
376a486
Compare
Narayanbhat166
approved these changes
Aug 23, 2023
inventvenkat
approved these changes
Aug 23, 2023
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Previously Webhooks were triggered when the payment status changes. The outgoing webhook was hyperswitch webhook.
In this PR , the outgoing webhook is converted to stripe compatible webhook based on metadata of merchant account.
Additional Changes
Slightly modifies the merchant_account api contract by adding the field '{"compatible_connector": "<Connector>"}' in metadata. The dashboard can add this field if required.
Motivation and Context
How did you test it?
Tested manually.
Created a merchant_account and updated the metadata to contain the field
"compatible_connector": "stripe"Created a payment and the webhook that was sent was stripe compatible.
Checklist
cargo +nightly fmt --allcargo clippy