Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mock_db): insert merchant for mock_db #1984

Merged
merged 10 commits into from
Aug 31, 2023
Merged

fix(mock_db): insert merchant for mock_db #1984

merged 10 commits into from
Aug 31, 2023

Conversation

ThisIsMani
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Fixes merchant not being inserted in mock db because id is not present.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

To fix mock db implementation for insert_merchant

How did you test it?

Using create_merchant_account api.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ThisIsMani ThisIsMani added A-framework Area: Framework C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 22, 2023
@ThisIsMani ThisIsMani added this to the August 2023 Milestone milestone Aug 22, 2023
@ThisIsMani ThisIsMani self-assigned this Aug 22, 2023
@ThisIsMani ThisIsMani requested a review from a team as a code owner August 22, 2023 14:38
@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 22, 2023
@ThisIsMani ThisIsMani added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Aug 23, 2023
@lsampras lsampras added this pull request to the merge queue Aug 31, 2023
Merged via the queue into main with commit fb39795 Aug 31, 2023
9 of 10 checks passed
@lsampras lsampras deleted the merchant-mock-db branch August 31, 2023 14:31
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@lsampras lsampras lsampras approved these changes

@jarnura jarnura Awaiting requested review from jarnura

@dracarys18 dracarys18 Awaiting requested review from dracarys18

Assignees

@ThisIsMani ThisIsMani

Labels
A-framework Area: Framework C-bug Category: Bug
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
August 2023 Milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThisIsMani @lsampras @SanchithHegde