-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): [Braintree] Add Authorize, Capture, Void, PSync, Refund, Rsync for Braintree GraphQL API #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bc6b8b4.
prasunna09
added
A-connector-integration
Area: Connector integration
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Aug 17, 2023
prasunna09
added
the
M-configuration-changes
Metadata: This PR involves configuration changes
label
Aug 17, 2023
AkshayaFoiger
requested review from
AkshayaFoiger
and removed request for
AkshayaFoiger
August 24, 2023 05:25
ArjunKarthik
requested changes
Aug 24, 2023
|
||
Ok(request) | ||
let connector_api_version = req.connector_api_version.clone(); | ||
if connector_api_version == Some("v2".to_string()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's move this to a method and reuse
|
||
match item.request.payment_method_data.clone() { | ||
api::PaymentMethodData::Card(_) => { | ||
const CHARGE_CREDIT_CARD_MUTATION: &str = "mutation ChargeCreditCard($input: ChargeCreditCardInput!) { chargeCreditCard(input: $input) { transaction { id legacyId createdAt amount { value currencyCode } status } } }"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep this globally
…tch into braintree-cards-refactor
jarnura
previously approved these changes
Aug 24, 2023
jarnura
approved these changes
Aug 24, 2023
ArjunKarthik
approved these changes
Aug 24, 2023
ArjunKarthik
added
S-ready-for-merge
and removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-connector-integration
Area: Connector integration
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
M-configuration-changes
Metadata: This PR involves configuration changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add Authorize, Capture, Void, PSync, Refund, Rsync for Braintree GraphQL version. Now we support both older version and newer version using config. A new field introduced in router data, where the value is being fetched from this config with key - "is_connector_new_version_braintree" with value true- GraphQL version(newer one) and false - Older version.
Additional Changes
Motivation and Context
How did you test it?
Payment Autocapture -
Payment Manual Capture -
Capture -
PSync -
Refund -
RSync -
Checklist
cargo +nightly fmt --all
cargo clippy