Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [Braintree] fix status mapping for braintree #1941

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

srujanchikke
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Previously status settled is declared in enums but not mapped .So the payment which goes to settled state remains processing even after force sync .This pr contains proper status mapping for connector braintree .

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@srujanchikke srujanchikke added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 16, 2023
@srujanchikke srujanchikke added this to the August 2023 Milestone milestone Aug 16, 2023
@srujanchikke srujanchikke requested a review from a team as a code owner August 16, 2023 08:24
@srujanchikke srujanchikke self-assigned this Aug 16, 2023
@ArjunKarthik ArjunKarthik added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 16, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Aug 16, 2023
Merged via the queue into main with commit d30fefb Aug 16, 2023
10 of 12 checks passed
@ArjunKarthik ArjunKarthik deleted the status_fix_braintree branch August 16, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants