feat(router): add total count for refunds list #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorvdixit88
added
C-feature
SanchithHegde
approved these changes
Aug 17, 2023
inventvenkat
requested changes
Aug 17, 2023
| merchant_account.storage_scheme, | ||
| ) | ||
| .await | ||
| .to_not_found_response(errors::ApiErrorResponse::InternalServerError)?; |
There was a problem hiding this comment.
Shouldn't this be 0 instead of error response?
There was a problem hiding this comment.
count 0 case is handled, error can occur in cases, such as DB is down or some unexpected behaviour.
| @@ -160,7 +162,9 @@ pub struct TimeRange { | |||
| #[derive(Debug, Clone, Eq, PartialEq, Deserialize, Serialize, ToSchema)] | |||
| pub struct RefundListResponse { | |||
| /// The number of refunds included in the list | |||
| pub size: usize, | |||
| pub count: usize, | |||
There was a problem hiding this comment.
This is not backward compatible.
There was a problem hiding this comment.
For now it is not being used
inventvenkat
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added support for total count of available refunds in refunds list. This will support better pagination and also work well with filters applied on refunds list.
Additional Changes
Motivation and Context
The current refund list api doesn't have support for proper pagination.
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy