Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): add total count for payments list #1912

Merged
merged 14 commits into from
Aug 29, 2023
Merged

feat(router): add total count for payments list #1912

merged 14 commits into from
Aug 29, 2023

Conversation

apoorvdixit88
Copy link
Contributor

@apoorvdixit88 apoorvdixit88 commented Aug 10, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added support for total count of available payments after applying filters on payments list. This will support better pagination.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

The current list api doesn't have support for proper pagination.

How did you test it?

Screenshot 2023-08-10 at 3 59 02 PM Screenshot 2023-08-10 at 3 56 43 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@apoorvdixit88 apoorvdixit88 added C-feature Category: Feature request or enhancement R-waiting-on-L1 Review: Waiting on L1 reviewer A-payments Area: payments labels Aug 10, 2023
@apoorvdixit88 apoorvdixit88 added this to the August 2023 Milestone milestone Aug 10, 2023
@apoorvdixit88 apoorvdixit88 self-assigned this Aug 10, 2023
@apoorvdixit88 apoorvdixit88 requested review from a team as code owners August 10, 2023 10:32
@apoorvdixit88 apoorvdixit88 changed the title feat(router): add total count of payments in payments list feat(router): add total count for payments list Aug 10, 2023
lsampras
lsampras requested changes Aug 10, 2023
View reviewed changes
crates/diesel_models/src/query/payment_attempt.rs Outdated Show resolved Hide resolved
crates/diesel_models/src/payment_attempt.rs Outdated Show resolved Hide resolved
crates/router/src/core/payments.rs Outdated Show resolved Hide resolved
crates/router/src/core/payments.rs Outdated Show resolved Hide resolved
crates/router/src/db/payment_attempt.rs Outdated Show resolved Hide resolved
crates/api_models/src/payments.rs Outdated Show resolved Hide resolved
crates/diesel_models/src/payment_attempt.rs Show resolved Hide resolved
crates/diesel_models/src/query/payment_attempt.rs Outdated Show resolved Hide resolved
crates/router/src/core/payments.rs Outdated Show resolved Hide resolved
lsampras
lsampras previously approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@lsampras lsampras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for the most part

crates/router/src/core/payments.rs Outdated Show resolved Hide resolved
@apoorvdixit88 apoorvdixit88 added R-waiting-on-L2 Review: Waiting on L2 reviewer and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Aug 17, 2023
Narayanbhat166
Narayanbhat166 previously approved these changes Aug 18, 2023
View reviewed changes
Narayanbhat166
Narayanbhat166 previously approved these changes Aug 21, 2023
View reviewed changes
@Narayanbhat166
Copy link
Member

please update the openapi file

@apoorvdixit88 apoorvdixit88 requested a review from a team as a code owner August 21, 2023 13:15
Narayanbhat166
Narayanbhat166 previously approved these changes Aug 21, 2023
View reviewed changes
@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author and removed R-waiting-on-L2 Review: Waiting on L2 reviewer labels Aug 21, 2023
@apoorvdixit88 apoorvdixit88 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Aug 24, 2023
lsampras
lsampras previously approved these changes Aug 24, 2023
View reviewed changes
@SanchithHegde SanchithHegde added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit 7a5c841 Aug 29, 2023
9 of 12 checks passed
@SanchithHegde SanchithHegde deleted the total-count-of-payments-list branch August 29, 2023 11:29
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer labels Aug 30, 2023
lsampras pushed a commit that referenced this pull request Sep 4, 2023
@apoorvdixit88 @lsampras
feat(router): add total count for payments list (#1912)
1598d01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@lsampras lsampras lsampras approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 left review comments

Assignees

@apoorvdixit88 apoorvdixit88

Labels
A-payments Area: payments C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
August 2023 Milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apoorvdixit88 @Narayanbhat166 @lsampras @SanchithHegde