Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [STAX] Add currency filter for payments through Stax #1911

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

deepanshu-iiitu
Copy link
Contributor

@deepanshu-iiitu deepanshu-iiitu commented Aug 10, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Connector Stax only supports payments through the default currency(USD). Added a filter to throw an error if any currency other than USD is used to process a transaction through Stax.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Bugfix: Added a filter to throw an error if any currency other than USD is used to process a transaction through Stax.

How did you test it?

Testing was carried out using Unit Tests.
Screenshot 2023-08-10 at 4 06 47 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@deepanshu-iiitu deepanshu-iiitu requested a review from a team as a code owner August 10, 2023 10:23
@deepanshu-iiitu deepanshu-iiitu added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Aug 10, 2023
@ArjunKarthik ArjunKarthik added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Aug 10, 2023
@ArjunKarthik ArjunKarthik added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 10, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit 5bc7592 Aug 10, 2023
13 checks passed
@ArjunKarthik ArjunKarthik deleted the add-stax-currency-filter branch August 10, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants