chore: remove spaces at beginning of commit messages when generating changelogs #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanchithHegde
added
C-bug
inventvenkat
approved these changes
Aug 9, 2023
Chethan-rao
approved these changes
Aug 9, 2023
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR updates the
git-clifftemplates to remove spaces at the beginning of the commit message.Motivation and Context
Because of the leading spaces in some commit messages, the offending commits were not being included in the release notes. This PR fixes that.
How did you test it?
Verified that the changelog generated does include the offending commits. One such PR was #1804, which was included in the
v1.15.0tag. For verifying my fix, I generated the changelog using the command:git cliff --config .github/git-cliff-changelog.toml v1.14.1..v1.15.0.Checklist
cargo +nightly fmt --allcargo clippy