Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [PayMe] Implement preprocessing flow for cards #1904

Merged
merged 12 commits into from
Aug 10, 2023
Merged

feat(connector): [PayMe] Implement preprocessing flow for cards #1904

merged 12 commits into from
Aug 10, 2023

Conversation

Sangamesh26
Copy link
Contributor

@Sangamesh26 Sangamesh26 commented Aug 9, 2023 •
edited
Loading

Type of Change

  • New feature

Description

Use Preprocessing flow for cards in payme instead of execute_pretasks, as we can eradicate 5xx with preprocessing flows.

Motivation and Context

Implement preprocessing for payme cards

How did you test it?

Handling 5xx for failures
Screen Shot 2023-08-09 at 5 54 25 PM

Happy case for card payments
Screen Shot 2023-08-09 at 2 32 42 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@Sangamesh26 Sangamesh26 added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payment-methods Area: Payment Methods labels Aug 9, 2023
@Sangamesh26 Sangamesh26 self-assigned this Aug 9, 2023
@Sangamesh26 Sangamesh26 requested review from a team as code owners August 9, 2023 10:44
ArjunKarthik
ArjunKarthik requested changes Aug 9, 2023
View reviewed changes
crates/router/src/connector/payme/transformers.rs Outdated Show resolved Hide resolved
crates/api_models/src/payments.rs Outdated Show resolved Hide resolved
crates/router/src/connector/payme.rs Outdated Show resolved Hide resolved
crates/router/src/connector/payme.rs Show resolved Hide resolved
crates/router/src/connector/payme/transformers.rs Show resolved Hide resolved
crates/router/src/connector/payme/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/payme/transformers.rs Outdated Show resolved Hide resolved
@ArjunKarthik ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Aug 9, 2023
@Sangamesh26 Sangamesh26 removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Aug 10, 2023
ArjunKarthik
ArjunKarthik previously approved these changes Aug 10, 2023
View reviewed changes
@ArjunKarthik ArjunKarthik added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 10, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit 38b9c07 Aug 10, 2023
16 of 18 checks passed
@ArjunKarthik ArjunKarthik deleted the remove_pre_execute_task_payme branch August 10, 2023 18:08
Sangamesh26 added a commit that referenced this pull request Aug 11, 2023
@Sangamesh26
feat(connector): [PayMe] Implement preprocessing flow for cards (#1904)
65273d0
ArjunKarthik pushed a commit that referenced this pull request Aug 11, 2023
@Sangamesh26
feat(connector): [PayMe] Implement preprocessing flow for cards (#1904)…
3d47aec 
… (#1922)
ArjunKarthik pushed a commit that referenced this pull request Aug 16, 2023
@Sangamesh26 @ArjunKarthik
feat(connector): [PayMe] Implement preprocessing flow for cards (#1904)…
abfad32 
… (#1922)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokkjag ashokkjag ashokkjag approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@Sangamesh26 Sangamesh26

Labels
A-connector-integration Area: Connector integration A-payment-methods Area: Payment Methods
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sangamesh26 @ArjunKarthik @SanchithHegde @Narayanbhat166 @ashokkjag