Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Square] Implement Card Payments for Square #1902

Merged
merged 33 commits into from
Aug 31, 2023
Merged

feat(connector): [Square] Implement Card Payments for Square #1902

merged 33 commits into from
Aug 31, 2023

Conversation

deepanshu-iiitu
Copy link
Contributor

@deepanshu-iiitu deepanshu-iiitu commented Aug 9, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Square is a payment connector from North America.
Add Card payment support for Square.

Supported Flows:

  • Authorize
  • Capture
  • PSync
  • Void
  • Refund
  • RSync

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Add Card Payments for Payments and Refunds flow for new connector square.

How did you test it?

Testing was carried out via Unit Tests
Screenshot 2023-08-09 at 1 47 09 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@deepanshu-iiitu deepanshu-iiitu requested review from a team as code owners August 9, 2023 08:17
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Aug 9, 2023
@deepanshu-iiitu deepanshu-iiitu changed the title Implement cards square feat(connector): [Square] Implement Card Payments for Square Aug 9, 2023
@deepanshu-iiitu deepanshu-iiitu removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Aug 9, 2023
@deepanshu-iiitu deepanshu-iiitu self-assigned this Aug 9, 2023
@deepanshu-iiitu deepanshu-iiitu added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 9, 2023
@deepanshu-iiitu deepanshu-iiitu added M-configuration-changes Metadata: This PR involves configuration changes M-api-contract-changes Metadata: This PR involves API contract changes and removed M-api-contract-changes Metadata: This PR involves API contract changes labels Aug 14, 2023
ArjunKarthik
ArjunKarthik requested changes Aug 22, 2023
View reviewed changes
crates/router/src/connector/square.rs Outdated Show resolved Hide resolved
crates/router/src/connector/square.rs Outdated Show resolved Hide resolved
crates/router/src/connector/square.rs Outdated Show resolved Hide resolved
crates/router/src/connector/square.rs Outdated Show resolved Hide resolved
crates/router/src/connector/square.rs Outdated Show resolved Hide resolved
crates/router/src/connector/square/transformers.rs Show resolved Hide resolved
crates/router/src/connector/square/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/square.rs Show resolved Hide resolved
crates/router/src/connector/square.rs Show resolved Hide resolved
crates/router/src/core/payments/tokenization.rs Show resolved Hide resolved
SamraatBansal
SamraatBansal previously approved these changes Aug 30, 2023
View reviewed changes
ArjunKarthik
ArjunKarthik requested changes Aug 31, 2023
View reviewed changes
crates/router/src/connector/square.rs Outdated Show resolved Hide resolved
crates/router/src/connector/square.rs Outdated Show resolved Hide resolved
crates/router/tests/connectors/utils.rs Outdated Show resolved Hide resolved
@ArjunKarthik ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Aug 31, 2023
@ArjunKarthik ArjunKarthik added S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Aug 31, 2023
@ArjunKarthik ArjunKarthik added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners labels Aug 31, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Aug 31, 2023
Merged via the queue into main with commit c9fe389 Aug 31, 2023
12 of 16 checks passed
@ArjunKarthik ArjunKarthik deleted the implement-cards-square branch August 31, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sangamesh26 Sangamesh26 Sangamesh26 approved these changes

@SamraatBansal SamraatBansal SamraatBansal approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@lsampras lsampras Awaiting requested review from lsampras

Assignees

@deepanshu-iiitu deepanshu-iiitu

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement M-configuration-changes Metadata: This PR involves configuration changes
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deepanshu-iiitu @ArjunKarthik @SanchithHegde @SamraatBansal @Sangamesh26