Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): add webhook source verification support for multiple mca of the same connector #1897

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

sai-harsha-vardhan
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add webhook source verification support for multiple mca of the same connector

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually
Multiple MCA
image

Source Verification
image

Single MCA
image

Source Verification
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 8, 2023
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Aug 8, 2023
@sai-harsha-vardhan sai-harsha-vardhan requested review from a team as code owners August 8, 2023 08:58
jarnura
jarnura previously approved these changes Aug 8, 2023
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit 3554fec Aug 10, 2023
10 of 12 checks passed
@Narayanbhat166 Narayanbhat166 deleted the fix-webhook-source-verification-multiple-mca branch August 10, 2023 10:02
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants