Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(payment_methods): add requires_cvv field to customer payment method list api object #1852

Merged
merged 9 commits into from
Aug 3, 2023

Conversation

Chethan-rao
Copy link
Contributor

@Chethan-rao Chethan-rao commented Aug 2, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added new field in the customer list payment method object to include requires_cvv field which specifies whether for a given merchant, cvv is a required_field to be collected. If an entry is found in config table, then requires_cvv is set to false i.e., by default cvv is made a required_field for all merchants

Requires db insertion into configs table with key as <merchant_id>_requires_cvv and config as false
DB query - insert into configs(key,config) values('<merchant_id>_requires_cvv',false);

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

ListPaymentMethodForCustomer object
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Chethan-rao Chethan-rao added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payment-methods Area: Payment Methods C-refactor Category: Refactor M-api-contract-changes Metadata: This PR involves API contract changes labels Aug 2, 2023
@Chethan-rao Chethan-rao added this to the July 2023 Release milestone Aug 2, 2023
@Chethan-rao Chethan-rao requested a review from a team as a code owner August 2, 2023 15:07
@Chethan-rao Chethan-rao self-assigned this Aug 2, 2023
@Chethan-rao Chethan-rao requested a review from a team as a code owner August 2, 2023 15:07
@Chethan-rao Chethan-rao requested a review from a team as a code owner August 2, 2023 18:18
@Chethan-rao Chethan-rao changed the title refactor(payment_methods): add requires_cvv field to customer list api object refactor(payment_methods): add requires_cvv field to customer payment method list api object Aug 2, 2023
Narayanbhat166
Narayanbhat166 previously approved these changes Aug 3, 2023
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Aug 3, 2023
Merged via the queue into main with commit 2dec2ca Aug 3, 2023
11 checks passed
@Narayanbhat166 Narayanbhat166 deleted the add-cvv-cond branch August 3, 2023 10:31
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-payment-methods Area: Payment Methods C-refactor Category: Refactor M-api-contract-changes Metadata: This PR involves API contract changes
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[FEATURE] add requires_cvv field to customer payment method list api object
3 participants