-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(payment_methods): add requires_cvv
field to customer payment method list api object
#1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chethan-rao
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
A-payment-methods
Area: Payment Methods
C-refactor
Category: Refactor
M-api-contract-changes
Metadata: This PR involves API contract changes
labels
Aug 2, 2023
Chethan-rao
changed the title
refactor(payment_methods): add
refactor(payment_methods): add Aug 2, 2023
requires_cvv
field to customer list api objectrequires_cvv
field to customer payment method list api object
Narayanbhat166
previously approved these changes
Aug 3, 2023
2 tasks
SanchithHegde
approved these changes
Aug 3, 2023
Narayanbhat166
approved these changes
Aug 3, 2023
Merged
15 tasks
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-payment-methods
Area: Payment Methods
C-refactor
Category: Refactor
M-api-contract-changes
Metadata: This PR involves API contract changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added new field in the customer list payment method object to include
requires_cvv
field which specifies whether for a given merchant, cvv is a required_field to be collected. If an entry is found in config table, then requires_cvv is set tofalse
i.e., by default cvv is made a required_field for all merchantsRequires db insertion into configs table with key as
<merchant_id>_requires_cvv
and config asfalse
DB query -
insert into configs(key,config) values('<merchant_id>_requires_cvv',false);
Additional Changes
Motivation and Context
How did you test it?
ListPaymentMethodForCustomer object
Checklist
cargo +nightly fmt --all
cargo clippy