Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webhooks): do not send duplicate webhooks #1850

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

Narayanbhat166
Copy link
Member

@Narayanbhat166 Narayanbhat166 commented Aug 2, 2023

Type of Change

  • New feature

Description

Hyperswitch triggers a webhook only when it receives a webhook. We will need to trigger a webhook for payments too, but in that case, if we receive a webhook from upstream, that will also trigger a webhook to the merchant. To avoid this, event id is generated using primary_resource_id and event_type. This will prevent the same event type webhook being repeated.

Additional Changes

  • This PR modifies the database schema

migrations/2023-08-01-165717_make_event_id_unique_for_events_table/down.sql
migrations/2023-08-01-165717_make_event_id_unique_for_events_table/up.sql

Motivation and Context

How did you test it?

  • Create a payment and test if webhooks are received in the webhook site.
Screenshot 2023-08-02 at 7 13 52 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@Narayanbhat166 Narayanbhat166 added A-core Area: Core flows C-feature Category: Feature request or enhancement M-database-changes Metadata: This PR involves database schema changes A-payments Area: payments labels Aug 2, 2023
@Narayanbhat166 Narayanbhat166 added this to the July 2023 Release milestone Aug 2, 2023
@Narayanbhat166 Narayanbhat166 self-assigned this Aug 2, 2023
@Narayanbhat166 Narayanbhat166 requested review from a team as code owners August 2, 2023 13:46
@Narayanbhat166 Narayanbhat166 changed the title feat(payments): add outgoing webhooks for payments fix(webhooks): do not send duplicate webhooks Aug 3, 2023
@NishantJoshi00 NishantJoshi00 added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Aug 3, 2023
Copy link
Member

@NishantJoshi00 NishantJoshi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 3, 2023
@jarnura jarnura enabled auto-merge August 3, 2023 07:38
@jarnura jarnura added this pull request to the merge queue Aug 3, 2023
Merged via the queue into main with commit 0d996b8 Aug 3, 2023
13 checks passed
@jarnura jarnura deleted the add_outgoing_webhooks_for_payments branch August 3, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows A-payments Area: payments C-feature Category: Feature request or enhancement M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants