-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webhooks): do not send duplicate webhooks #1850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narayanbhat166
added
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
M-database-changes
Metadata: This PR involves database schema changes
A-payments
Area: payments
labels
Aug 2, 2023
Narayanbhat166
changed the title
feat(payments): add outgoing webhooks for payments
fix(webhooks): do not send duplicate webhooks
Aug 3, 2023
NishantJoshi00
added
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Aug 3, 2023
NishantJoshi00
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
jarnura
approved these changes
Aug 3, 2023
jarnura
added
S-ready-for-merge
and removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Aug 3, 2023
Narayanbhat166
added a commit
that referenced
this pull request
Aug 3, 2023
Narayanbhat166
added a commit
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core flows
A-payments
Area: payments
C-feature
Category: Feature request or enhancement
M-database-changes
Metadata: This PR involves database schema changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Hyperswitch triggers a webhook only when it receives a webhook. We will need to trigger a webhook for payments too, but in that case, if we receive a webhook from upstream, that will also trigger a webhook to the merchant. To avoid this, event id is generated using
primary_resource_id
andevent_type
. This will prevent the same event type webhook being repeated.Additional Changes
migrations/2023-08-01-165717_make_event_id_unique_for_events_table/down.sql
migrations/2023-08-01-165717_make_event_id_unique_for_events_table/up.sql
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy