fix: request amount fix for trustpay apple pay #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sangamesh26
added
A-connector-integration
Sangamesh26
requested review from
ArjunKarthik,
sai-harsha-vardhan and
Abhicodes-crypto
sai-harsha-vardhan
approved these changes
Aug 1, 2023
Abhicodes-crypto
approved these changes
Aug 1, 2023
ArjunKarthik
approved these changes
Aug 1, 2023
| @@ -849,23 +849,33 @@ impl TryFrom<&types::PaymentsPreProcessingRouterData> for TrustpayCreateIntentRe | |||
| .as_ref() | |||
| .map(|pmt| matches!(pmt, diesel_models::enums::PaymentMethodType::GooglePay)); | |||
|
|
|||
| let request_amount = item | |||
There was a problem hiding this comment.
In Preprocessing amount and currency need not to be optional fields. Please check this if any changes required take it in separate PR
SanchithHegde
removed
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
For Trustpay Apple Pay, we were sending amount in cents.This PR fixes amount issue by converting to currency base unit.
Motivation and Context
Fix amount issue
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy