Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [Payme] Fix refund request fields #1831

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

ArjunKarthik
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Refund does not require field "payme_client_key" in the request

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

As suggested by payme connector support removed "payme_client_key" field from the refund request

How did you test it?

Manual Testing
Screen Shot 2023-08-01 at 11 51 59 AM

Screen Shot 2023-08-01 at 11 51 43 AM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ArjunKarthik ArjunKarthik requested a review from a team as a code owner August 1, 2023 06:35
@ArjunKarthik ArjunKarthik self-assigned this Aug 1, 2023
@ArjunKarthik ArjunKarthik added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 1, 2023
@ArjunKarthik ArjunKarthik added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 1, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Aug 1, 2023
Merged via the queue into main with commit 6f8be0c Aug 1, 2023
11 checks passed
@ArjunKarthik ArjunKarthik deleted the payme-refund-fix branch August 1, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants