Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Adyen] Implement Momo Atm(Napas) in Card Redirects #1820

Merged
merged 11 commits into from
Aug 8, 2023
Merged

feat(connector): [Adyen] Implement Momo Atm(Napas) in Card Redirects #1820

merged 11 commits into from
Aug 8, 2023

Conversation

Sakilmostak
Copy link
Contributor

@Sakilmostak Sakilmostak commented Jul 31, 2023 •
edited by ArjunKarthik
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Through MoMo, they offer ATM card payments through the local Napas network in Vietnam

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screen Shot 2023-07-31 at 1 05 07 PM
Screen Shot 2023-07-31 at 1 09 13 PM
Screen Shot 2023-07-31 at 1 10 51 PM
Screen Shot 2023-07-31 at 1 11 00 PM
Screen Shot 2023-07-31 at 1 11 07 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jul 31, 2023
@Sakilmostak Sakilmostak self-assigned this Jul 31, 2023
@Sakilmostak Sakilmostak requested review from a team as code owners July 31, 2023 07:51
srujanchikke
srujanchikke previously approved these changes Jul 31, 2023
View reviewed changes
@srujanchikke srujanchikke added R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jul 31, 2023
@Sakilmostak Sakilmostak requested review from a team, jarnura and ashokkjag as code owners August 2, 2023 13:30
@bernard-eugine bernard-eugine added this to the August 2023 Milestone milestone Aug 4, 2023
Base automatically changed from card_redirection to main August 8, 2023 07:17
@ArjunKarthik ArjunKarthik dismissed srujanchikke’s stale review August 8, 2023 07:17

The base branch was changed.

@ArjunKarthik ArjunKarthik added S-ready-for-merge and removed R-waiting-on-L2 Review: Waiting on L2 reviewer labels Aug 8, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Aug 8, 2023
Merged via the queue into main with commit 8ae6737 Aug 8, 2023
13 checks passed
@ArjunKarthik ArjunKarthik deleted the adyen_napas branch August 8, 2023 13:43
@SanchithHegde SanchithHegde removed S-ready-for-merge R-L1-completed Review: L1 Review completed labels Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@srujanchikke srujanchikke srujanchikke left review comments

@jagan-jaya jagan-jaya Awaiting requested review from jagan-jaya

@jarnura jarnura Awaiting requested review from jarnura

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@Sakilmostak Sakilmostak

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
August 2023 Milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Sakilmostak @ArjunKarthik @SanchithHegde @srujanchikke @bernard-eugine @Sangamesh26