Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [Adyen] Add support for card redirection (KNET, BENEFIT) #1816

Merged
merged 14 commits into from
Aug 8, 2023

Conversation

Sangamesh26
Copy link
Contributor

@Sangamesh26 Sangamesh26 commented Jul 29, 2023

Type of Change

  • New feature

Description

Add support for card redirection (ex: Knet,Benefit) through Adyen.
Api contract :

    "payment_method": "card_redirect",
    "payment_method_type": "knet",
    "payment_method_data": {
        "card_redirect": {
            "knet": {}
        }
    }

Replace payment_method_type to benefit for benefit payment method in the above api contract

Additional Changes

  • This PR modifies the API contract

Motivation and Context

Add support for card redirection

How did you test it?

Screen Shot 2023-08-02 at 6 25 29 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@Sangamesh26 Sangamesh26 added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payment-methods Area: Payment Methods M-api-contract-changes Metadata: This PR involves API contract changes labels Jul 29, 2023
@Sangamesh26 Sangamesh26 self-assigned this Jul 29, 2023
@Sangamesh26 Sangamesh26 requested review from a team as code owners July 29, 2023 14:09
@Sangamesh26 Sangamesh26 requested a review from a team as a code owner July 29, 2023 14:14
crates/router/src/connector/adyen/transformers.rs Outdated Show resolved Hide resolved
crates/api_models/src/payments.rs Outdated Show resolved Hide resolved
ArjunKarthik
ArjunKarthik previously approved these changes Aug 2, 2023
ashokkjag
ashokkjag previously approved these changes Aug 2, 2023
@Sangamesh26 Sangamesh26 dismissed stale reviews from ashokkjag and ArjunKarthik via 4065e78 August 3, 2023 12:41
ashokkjag
ashokkjag previously approved these changes Aug 3, 2023
ArjunKarthik
ArjunKarthik previously approved these changes Aug 3, 2023
@Sangamesh26 Sangamesh26 dismissed stale reviews from ArjunKarthik and ashokkjag via 58ff22e August 3, 2023 20:21
@bernard-eugine bernard-eugine added this to the August 2023 Milestone milestone Aug 4, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Aug 8, 2023
Merged via the queue into main with commit 62461f1 Aug 8, 2023
10 of 12 checks passed
@ArjunKarthik ArjunKarthik deleted the card_redirection branch August 8, 2023 07:17
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed S-ready-for-merge labels Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration A-payment-methods Area: Payment Methods M-api-contract-changes Metadata: This PR involves API contract changes
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

5 participants