-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): [Adyen] Add support for card redirection (KNET, BENEFIT) #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sangamesh26
added
A-connector-integration
Area: Connector integration
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
A-payment-methods
Area: Payment Methods
M-api-contract-changes
Metadata: This PR involves API contract changes
labels
Jul 29, 2023
ArjunKarthik
requested changes
Aug 2, 2023
ArjunKarthik
previously approved these changes
Aug 2, 2023
ashokkjag
previously approved these changes
Aug 2, 2023
Sangamesh26
dismissed stale reviews from ashokkjag and ArjunKarthik
via
August 3, 2023 12:41
4065e78
ArjunKarthik
approved these changes
Aug 3, 2023
ashokkjag
previously approved these changes
Aug 3, 2023
ArjunKarthik
previously approved these changes
Aug 3, 2023
Sangamesh26
dismissed stale reviews from ArjunKarthik and ashokkjag
via
August 3, 2023 20:21
58ff22e
ArjunKarthik
approved these changes
Aug 8, 2023
ashokkjag
approved these changes
Aug 8, 2023
SanchithHegde
removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
S-ready-for-merge
labels
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-connector-integration
Area: Connector integration
A-payment-methods
Area: Payment Methods
M-api-contract-changes
Metadata: This PR involves API contract changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add support for card redirection (ex: Knet,Benefit) through Adyen.
Api contract :
Replace payment_method_type to
benefit
for benefit payment method in the above api contractAdditional Changes
Motivation and Context
Add support for card redirection
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy