Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add diesel migration to update local db #1812

Merged
merged 17 commits into from
Aug 11, 2023
Merged

fix: add diesel migration to update local db #1812

merged 17 commits into from
Aug 11, 2023

Conversation

kritikmodi
Copy link
Contributor

@kritikmodi kritikmodi commented Jul 28, 2023 •
edited
Loading

Type of Change

  • Bugfix

Description

This is a part of the attempt to make database even across all environments. This PR contains the migrations for local database.

Additional Changes

  • This PR modifies the database schema

Motivation and Context

This PR closes #1809.

How did you test it?

Compiles

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@kritikmodi kritikmodi requested a review from a team as a code owner July 28, 2023 12:00
@kritikmodi kritikmodi changed the title fix: add diesel migration to fix local db fix: add diesel migration to update local db Jul 28, 2023
@kritikmodi kritikmodi self-assigned this Jul 28, 2023
@kritikmodi kritikmodi added C-bug Category: Bug M-database-changes Metadata: This PR involves database schema changes labels Jul 28, 2023
@kritikmodi kritikmodi added the P-high Priority: High label Jul 28, 2023
@kritikmodi kritikmodi added this to the July 2023 Release milestone Jul 28, 2023
@kritikmodi kritikmodi mentioned this pull request Aug 7, 2023
Closed
4 tasks
SanchithHegde
SanchithHegde reviewed Aug 7, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

migrations/2023-07-28-111829_update_columns_to_fix_db_diff/up.sql Outdated Show resolved Hide resolved
migrations/2023-07-28-111829_update_columns_to_fix_db_diff/up.sql Outdated Show resolved Hide resolved
@kritikmodi kritikmodi requested review from a team, jarnura and ashokkjag as code owners August 8, 2023 09:32
inventvenkat
inventvenkat previously approved these changes Aug 8, 2023
View reviewed changes
SanchithHegde
SanchithHegde previously approved these changes Aug 8, 2023
View reviewed changes
@inventvenkat inventvenkat added this pull request to the merge queue Aug 11, 2023
Merged via the queue into main with commit 97a495c Aug 11, 2023
10 checks passed
@inventvenkat inventvenkat deleted the issue-1809 branch August 11, 2023 09:48
@SanchithHegde SanchithHegde removed the P-high Priority: High label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jarnura jarnura jarnura approved these changes

@inventvenkat inventvenkat inventvenkat approved these changes

@dracarys18 dracarys18 Awaiting requested review from dracarys18

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

@tinu-hareesswar tinu-hareesswar Awaiting requested review from tinu-hareesswar

@NishantJoshi00 NishantJoshi00 Awaiting requested review from NishantJoshi00

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

Assignees

@kritikmodi kritikmodi

Labels
C-bug Category: Bug M-database-changes Metadata: This PR involves database schema changes
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
August 2023 Milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Diesel migration to update local database schema
6 participants
@kritikmodi @inventvenkat @jarnura @SanchithHegde @Narayanbhat166 @bernard-eugine