Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(errors): add GenericDuplicateError inApiErrorResponse #1792

Merged
merged 2 commits into from
Jul 26, 2023
Merged

feat(errors): add GenericDuplicateError inApiErrorResponse #1792

merged 2 commits into from
Jul 26, 2023

Conversation

sai-harsha-vardhan
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add generic_duplicate_error in api_error_response

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Compiler guided

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 26, 2023
@sai-harsha-vardhan sai-harsha-vardhan added this to the July 2023 Release milestone Jul 26, 2023
@sai-harsha-vardhan sai-harsha-vardhan requested review from a team as code owners July 26, 2023 08:15
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Jul 26, 2023
@bernard-eugine bernard-eugine added the P-high Priority: High label Jul 26, 2023
Narayanbhat166
Narayanbhat166 previously approved these changes Jul 26, 2023
View reviewed changes
@SanchithHegde SanchithHegde changed the title feat(router): add generic_duplicate_error in api_error_response feat(router): add GenericDuplicateError inApiErrorResponse Jul 26, 2023
@SanchithHegde SanchithHegde changed the title feat(router): add GenericDuplicateError inApiErrorResponse feat(errors): add GenericDuplicateError inApiErrorResponse Jul 26, 2023
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Jul 26, 2023
Merged via the queue into main with commit 7f94716 Jul 26, 2023
@Narayanbhat166 Narayanbhat166 deleted the add-generic-duplicate-error branch July 26, 2023 14:12
@SanchithHegde SanchithHegde removed P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Abhicodes-crypto Abhicodes-crypto Awaiting requested review from Abhicodes-crypto

Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
July 2023 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@sai-harsha-vardhan @SanchithHegde @Narayanbhat166 @Abhicodes-crypto @bernard-eugine