Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [Klarna] Handle error response with both error_messages and error_message fields #1783

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

ArjunKarthik
Copy link
Contributor

@ArjunKarthik ArjunKarthik commented Jul 24, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Incase of error, connector either return error_messages or error_message. Both should be handled in the error scenario

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

To fix deserialization error in case of error response from connector

How did you test it?

Screen Shot 2023-07-26 at 8 13 38 PM Screen Shot 2023-07-26 at 8 10 47 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ArjunKarthik ArjunKarthik added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 24, 2023
@ArjunKarthik ArjunKarthik requested a review from a team as a code owner July 24, 2023 20:00
@ArjunKarthik ArjunKarthik self-assigned this Jul 24, 2023
@ArjunKarthik ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jul 24, 2023
@bernard-eugine bernard-eugine added the P-high Priority: High label Jul 26, 2023
@ArjunKarthik ArjunKarthik removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jul 26, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Jul 26, 2023
Merged via the queue into main with commit 9cfdce0 Jul 26, 2023
@ArjunKarthik ArjunKarthik deleted the KlarnaErrorHandling branch July 26, 2023 15:29
@SanchithHegde SanchithHegde removed P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants