fix(connector): [Paypal] fix amount to its currency base unit #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasunna09
added
A-connector-integration
ArjunKarthik
previously approved these changes
Jul 24, 2023
ashokkjag
reviewed
Jul 24, 2023
| if currency.is_zero_decimal_currency() { | ||
| Ok(amount_f64.to_string()) | ||
| } else { | ||
| Ok(format!("{amount_f64:.2}")) |
There was a problem hiding this comment.
Should you vary based on 2 or 3 decimal currency?
There was a problem hiding this comment.
As far as we checked there are no connectors which accepts 3 digit decimals. Currently this method is being used in PayPal only, which don't accept 3 digit decimals for 3 decimal currency.
ArjunKarthik
approved these changes
Jul 25, 2023
SanchithHegde
approved these changes
Jul 25, 2023
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Fix amount to its currency base unit.
ref for currency decimal - https://docs.adyen.com/development-resources/currency-codes
Additional Changes
Motivation and Context
How did you test it?
For JPY
For USD, We are converting cents to dollars
Checklist
cargo +nightly fmt --allcargo clippy