Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fix): [Mollie] Add support for both HeaderKey and BodyKey AuthType #1761

Merged
merged 2 commits into from
Jul 25, 2023
Merged

refactor(fix): [Mollie] Add support for both HeaderKey and BodyKey AuthType #1761

merged 2 commits into from
Jul 25, 2023

Conversation

swangi-kumari
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR will work for these following scenarios:

  1. If auth_type is BodyKey , all the Mollie payment methods will work fine.
  2. If auth_type is HeaderKey, except "Mollie card 3ds" all other payment methods will work fine.
  3. If auth_type is HeaderKey, "Mollie card 3ds" will not work and give an "Internal Server Error."

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Using Postman.
Screen Shot 2023-07-20 at 4 14 13 PM
Screen Shot 2023-07-20 at 4 15 02 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@swangi-kumari swangi-kumari added the A-connector-integration Area: Connector integration label Jul 20, 2023
@swangi-kumari swangi-kumari self-assigned this Jul 20, 2023
@swangi-kumari swangi-kumari requested a review from a team as a code owner July 20, 2023 10:46
@ArjunKarthik
Copy link
Contributor

@swangi-kumari is dashboard informed about this change?

@ArjunKarthik ArjunKarthik added this pull request to the merge queue Jul 25, 2023
Merged via the queue into main with commit 07c60f8 Jul 25, 2023
@ArjunKarthik ArjunKarthik deleted the fix-mollie-auth-type branch July 25, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

Assignees

@swangi-kumari swangi-kumari

Labels
A-connector-integration Area: Connector integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swangi-kumari @ArjunKarthik @jagan-jaya @srujanchikke