Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Boku] Template generation #1760

Merged
merged 6 commits into from
Jul 25, 2023
Merged

feat(connector): [Boku] Template generation #1760

merged 6 commits into from
Jul 25, 2023

Conversation

Sakilmostak
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Boku is a payment connector which provides service majorly in South-Asian countries

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jul 20, 2023
@Sakilmostak Sakilmostak self-assigned this Jul 20, 2023
@Sakilmostak Sakilmostak requested review from a team, jarnura and ashokkjag as code owners July 20, 2023 09:37
prasunna09
prasunna09 requested changes Jul 20, 2023
View reviewed changes
crates/api_models/src/enums.rs Outdated Show resolved Hide resolved
crates/router/src/connector/boku/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/boku/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/boku/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/boku/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/core/payments/flows.rs Outdated Show resolved Hide resolved
crates/router/src/core/payments/flows.rs Outdated Show resolved Hide resolved
crates/api_models/src/enums.rs Outdated Show resolved Hide resolved
crates/api_models/src/enums.rs Outdated Show resolved Hide resolved
crates/router/tests/connectors/sample_auth.toml Outdated Show resolved Hide resolved
@prasunna09 prasunna09 added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jul 20, 2023
@Sakilmostak Sakilmostak removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jul 24, 2023
@prasunna09 prasunna09 added R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jul 24, 2023
@ArjunKarthik ArjunKarthik added R-L2-completed Review: L2 Review completed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed R-waiting-on-L2 Review: Waiting on L2 reviewer labels Jul 24, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Jul 25, 2023
@ArjunKarthik ArjunKarthik added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 25, 2023
Merged via the queue into main with commit 78c6cce Jul 25, 2023
@ArjunKarthik ArjunKarthik deleted the boku_template branch July 25, 2023 07:30
@SanchithHegde SanchithHegde removed S-ready-for-merge R-L1-completed Review: L1 Review completed R-L2-completed Review: L2 Review completed labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasunna09 prasunna09 prasunna09 approved these changes

@ashokkjag ashokkjag ashokkjag approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@jarnura jarnura Awaiting requested review from jarnura

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

Assignees

@Sakilmostak Sakilmostak

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sakilmostak @ArjunKarthik @ashokkjag @prasunna09 @SanchithHegde