Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): [Paypal] Fix payment status for PayPal cards #1749

Merged
merged 7 commits into from
Jul 24, 2023
Merged

fix(connector): [Paypal] Fix payment status for PayPal cards #1749

merged 7 commits into from
Jul 24, 2023

Conversation

prasunna09
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Fix status for PayPal cards. We have order status and payment status in the response sent by PayPal. Initially we were relying on order status which is not accurate. So updated to PayPal Payment Status.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screen Shot 2023-07-19 at 4 29 46 PM Screen Shot 2023-07-19 at 4 26 52 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prasunna09 prasunna09 added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-configuration-changes Metadata: This PR involves configuration changes labels Jul 19, 2023
@prasunna09 prasunna09 added this to the July 2023 Release milestone Jul 19, 2023
@prasunna09 prasunna09 requested a review from a team as a code owner July 19, 2023 13:42
@prasunna09 prasunna09 self-assigned this Jul 19, 2023
@prasunna09 prasunna09 requested a review from a team as a code owner July 19, 2023 13:42
jagan-jaya
jagan-jaya previously approved these changes Jul 19, 2023
View reviewed changes
@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 19, 2023
@prasunna09 prasunna09 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jul 20, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Jul 24, 2023
Merged via the queue into main with commit 88b4b96 Jul 24, 2023
@ArjunKarthik ArjunKarthik deleted the fix-paypal-cards branch July 24, 2023 12:11
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed S-ready-for-merge labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

@jarnura jarnura Awaiting requested review from jarnura

Assignees

@prasunna09 prasunna09

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug M-configuration-changes Metadata: This PR involves configuration changes
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
July 2023 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@prasunna09 @jagan-jaya @ArjunKarthik @Narayanbhat166 @SanchithHegde