Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): [PowerTranz] error message from response_code in absence of errors object & comment billing and shipping as it is optional #1738

Merged
merged 4 commits into from
Jul 19, 2023
Merged

fix(connector): [PowerTranz] error message from response_code in absence of errors object & comment billing and shipping as it is optional #1738

merged 4 commits into from
Jul 19, 2023

Conversation

ArjunKarthik
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

capture error message from response_code whenever errors object not present

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screen Shot 2023-07-18 at 8 51 46 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ArjunKarthik ArjunKarthik added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 18, 2023
@ArjunKarthik ArjunKarthik requested a review from a team as a code owner July 18, 2023 15:27
@ArjunKarthik ArjunKarthik self-assigned this Jul 18, 2023
Narayanbhat166
Narayanbhat166 previously approved these changes Jul 18, 2023
View reviewed changes
jagan-jaya
jagan-jaya previously approved these changes Jul 18, 2023
View reviewed changes
@ArjunKarthik ArjunKarthik changed the title fix(connector): [PowerTranz] capture error message from response_code whenever errors object not present fix(connector): [PowerTranz] error message from response_code in absence of errors object & comment billing and shipping as it is optional Jul 18, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Jul 19, 2023
Merged via the queue into main with commit 54f7ab7 Jul 19, 2023
@ArjunKarthik ArjunKarthik deleted the powertranz-error-handling branch July 19, 2023 08:36
ArjunKarthik added a commit that referenced this pull request Jul 19, 2023
@ArjunKarthik
fix(connector): [PowerTranz] error message from response_code in abse…
9e64edc 
…nce of errors object & comment billing and shipping as it is optional (#1738)
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamraatBansal SamraatBansal SamraatBansal approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

Assignees

@ArjunKarthik ArjunKarthik

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArjunKarthik @jagan-jaya @Narayanbhat166 @SamraatBansal @SanchithHegde