feat(router): add attempt_count field in attempt update record of payment_intent #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-harsha-vardhan
added
A-core
Narayanbhat166
approved these changes
Jul 17, 2023
| @@ -134,8 +134,9 @@ pub enum PaymentIntentUpdate { | |||
| order_details: Option<Vec<pii::SecretSerdeValue>>, | |||
| metadata: Option<pii::SecretSerdeValue>, | |||
| }, | |||
| PaymentAttemptUpdate { | |||
| PaymentAttemptAndAttemptCountUpdate { | |||
There was a problem hiding this comment.
Should we rename this as AutoRetryAttemptUpdate and below variant as ManualRetryAttemptUpdate ? I guess these structs are not used in other cases
There was a problem hiding this comment.
But these names imply what are we updating, so this would be better even if it's used anywhere else in future right!
Abhicodes-crypto
approved these changes
Jul 17, 2023
SanchithHegde
approved these changes
Jul 17, 2023
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
While updating the payment_intent's active attempt id in automatic retries we need to update attempt_count too. To support that have added attempt_count field in attempt update record of payment_intent
Additional Changes
Motivation and Context
How did you test it?
Compiler guided
Checklist
cargo +nightly fmt --allcargo clippy