feat(router): add support for multiple partial capture #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrithikesh026
added
A-core
hrithikesh026
requested review from
jarnura,
SanchithHegde,
Narayanbhat166 and
Sangamesh26
| return storage_enums::AttemptStatus::Charged; | ||
| } | ||
| let status_count_map = self.get_status_count(); | ||
| if status_count_map.get(&storage_enums::CaptureStatus::Charged) > Some(&0) { |
There was a problem hiding this comment.
I see that this hashmap is used only to get the number of charged captures. Is there any reason that we are creating this hashmap, rather than just counting the status of charged captures?
There was a problem hiding this comment.
Just in case, in future, we might need count of other status also.
jarnura
previously approved these changes
Aug 7, 2023
Narayanbhat166
previously approved these changes
Aug 7, 2023
15 tasks
jarnura
added
S-ready-for-merge
and removed
S-waiting-on-review
sai-harsha-vardhan
previously approved these changes
Aug 8, 2023
hrithikesh026
dismissed stale reviews from sai-harsha-vardhan, Narayanbhat166, and jarnura
via
9ecda5c
hrithikesh026
requested review from
jarnura,
Narayanbhat166 and
sai-harsha-vardhan
sai-harsha-vardhan
approved these changes
Aug 8, 2023
jarnura
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add feature to support multiple partial capture.
Any payment created with
capture_methodasmanual_multiplewill be considered as authorization made for multiple capture.For each partial manual capture request, we will create an entry in captures table. This can be used to sync captures with the connector.
automatic capture and single manual capture will work like before.
Additional Changes
Motivation and Context
How did you test it?
Manual
This change does not interfere with existing manual capture flow.
Create a payment with capture_method: manual
Capture the payment.
Status should change to succeeded. As expected.
Checklist
cargo +nightly fmt --allcargo clippy